Here are 2 links to help you revise (see grammar corner 1) preterit or present perfect?  for, since and ago